feat: add option to attach anvil logs to playwright report #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
reviewed
Feb 27, 2025
Rubilmax
reviewed
Feb 28, 2025
Comment on lines
+10
to
+31
| const attachLogToPlaywright = (testInfo: TestInfo) => { | ||
| const anvilLogs: string[] = []; | ||
|
|
||
| const attachLog = (message: string) => { | ||
| anvilLogs.push(message); | ||
| }; | ||
|
|
||
| const onClose = (message: string) => { | ||
| attachLog(message); | ||
|
|
||
| testInfo.attach("Anvil Logs", { | ||
| body: anvilLogs.join("\n"), | ||
| contentType: "text/plain", | ||
| }); | ||
| }; | ||
|
|
||
| return { | ||
| onMessage: attachLog, | ||
| onError: attachLog, | ||
| onClose: onClose, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
To me this should be end user code because we're preventing devs from passing their own callbacks to createViemTest
I would simply expect the same optional argument callbacks?: AnvilProcessCallbacks
And for its vitest counterpart too! (also named createViemTest)
There was a problem hiding this comment.
Don't you think that making it native to your playwright wrapper is a good use case?
But happy to move it wherever you want or even outside of the repo.
There was a problem hiding this comment.
We can export the resulting object (the 3 callbacks) as a constant attachLogs from this file if you want! So you just have to pass it as the third optional parameter, in place of callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createViemTestto playwright report.Can be seen here:
