Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorted withdrawals #15

Merged
merged 7 commits into from
Feb 17, 2024
Merged

Conversation

MathisGD
Copy link
Contributor

elegant idea of @peyha

withdrawals are required to be sorted, which allows to check that there is no duplicate in linear time instead of quadratic

@MathisGD MathisGD self-assigned this Feb 16, 2024
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Documentation and test would be nice before merging

@adhusson adhusson requested a review from QGarchery February 16, 2024 19:34
MathisGD and others added 3 commits February 17, 2024 11:07
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Copy link
Contributor Author

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MathisGD MathisGD merged commit 0bb0ad6 into feat/flows-and-eth-fee Feb 17, 2024
1 check passed
@MathisGD MathisGD deleted the perf/sorted-withdrawals branch February 17, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants