-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settable owner #14
settable owner #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use Ownable
from OZ and don't bother with code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency
@@ -69,8 +69,11 @@ interface IPublicAllocatorBase { | |||
external | |||
payable; | |||
|
|||
/// @notice Sets the current fee. | |||
function setFee(uint256 _fee) external; | |||
/// @notice Set the owner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// @notice Set the owner. | |
/// @notice Sets the owner. |
/// @notice Set the owner. | ||
function setOwner(address newOwner) external; | ||
|
||
/// @notice Set the fee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// @notice Set the fee. | |
/// @notice Sets the fee. |
No description provided.