Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settable owner #14

Merged
merged 2 commits into from
Feb 17, 2024
Merged

settable owner #14

merged 2 commits into from
Feb 17, 2024

Conversation

MathisGD
Copy link
Contributor

No description provided.

@MathisGD MathisGD self-assigned this Feb 16, 2024
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use Ownable from OZ and don't bother with code

QGarchery

This comment was marked as outdated.

Copy link
Contributor Author

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MathisGD MathisGD merged commit 8c9b788 into feat/flows-and-eth-fee Feb 17, 2024
1 check passed
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency

@@ -69,8 +69,11 @@ interface IPublicAllocatorBase {
external
payable;

/// @notice Sets the current fee.
function setFee(uint256 _fee) external;
/// @notice Set the owner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// @notice Set the owner.
/// @notice Sets the owner.

/// @notice Set the owner.
function setOwner(address newOwner) external;

/// @notice Set the fee.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// @notice Set the fee.
/// @notice Sets the fee.

@MathisGD MathisGD deleted the feat/settable-owner branch February 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants