-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Certora] Check Missing Reverts #98
Conversation
As is, I dislike having that much spec files but, I'm afraid it's hard to do less without harnessing. A harness could be used to expose the internal function ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice 🔥
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: Colin | Morpho 🦋 <colin@morpho.xyz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, otherwise looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can try to remove some safe requires. Below is an example of how we could do it for mintRevertConditions
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: Colin | Morpho 🦋 <colin@morpho.xyz>
Signed-off-by: Colin | Morpho 🦋 <colin@morpho.xyz>
This PR: check revert conditions.
It provides rules to exhaustively check reverts conditions.
The OZ specs do not check everything we'd like to verify.
Please ensure that