Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: errors #4

Closed
wants to merge 1 commit into from
Closed

fix: errors #4

wants to merge 1 commit into from

Conversation

Jean-Grimal
Copy link
Contributor

Require can only take strings as inputs, not custom errors

The other solution (if we want to keep custom errors) is to replace require by if + revert

MerlinEgalite
MerlinEgalite requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure https://soliditylang.org/blog/2024/05/21/solidity-0.8.26-release-announcement/

@Jean-Grimal
Copy link
Contributor Author

I'm not sure https://soliditylang.org/blog/2024/05/21/solidity-0.8.26-release-announcement/

Indeed, but we should change the solidity version to 0.8.26 then

@MerlinEgalite
Copy link
Contributor

I'm not sure https://soliditylang.org/blog/2024/05/21/solidity-0.8.26-release-announcement/

Indeed, but we should change the solidity version to 0.8.26 then

Yes I think we will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jean-Grimal @MerlinEgalite