-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Certora] Delegation invariant #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's missing a couple of things to be usable:
- remove the require that
sumOfBalances
is greater than an account balance - use the new
sumOfBalance
definition to show that it's greater than the sum of balances of n accounts (with n = 1 or 2)
QGarchery
reviewed
Dec 4, 2024
chore: fix formatting Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: Colin | Morpho 🦋 <colin@morpho.xyz>
QGarchery
previously approved these changes
Dec 4, 2024
MathisGD
reviewed
Dec 5, 2024
Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com> Signed-off-by: Colin | Morpho 🦋 <colin@morpho.xyz>
QGarchery
previously approved these changes
Dec 5, 2024
MathisGD
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
impressive work!
MathisGD
previously approved these changes
Dec 6, 2024
QGarchery
previously approved these changes
Dec 6, 2024
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: Colin | Morpho 🦋 <colin@morpho.xyz>
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: Colin | Morpho 🦋 <colin@morpho.xyz>
QGarchery
approved these changes
Dec 6, 2024
MathisGD
approved these changes
Dec 6, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the specification for more desired invariants.
These are assumed in other rules so it's good to have them proved to hold.
It uses specification technique suggested by the Certora team. The technique is a bit sophisticated as it involves exhaustively specifying many intermediate properties and using quantificators.
TODO: