(ElgFormat.Reader): moved output bounds check into loop body.

morkt · Jul 19, 2015 · c8d7066 · c8d7066
1 parent e6dd091
commit c8d7066
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/ArcFormats/ImageELG.cs b/ArcFormats/ImageELG.cs
@@ -155,10 +155,10 @@ void UnpackPalette ()
             void UnpackIndexed (byte[] output)
             {
                 int dst = 0;
-                while (dst < m_output.Length)
+                for (;;)
                 {
                     byte flags = m_input.ReadByte();
-                    if (0xff == flags)
+                    if (0xff == flags || dst >= m_output.Length)
                         break;
                     int count, pos;
 
@@ -228,10 +228,10 @@ void UnpackIndexed (byte[] output)
             void UnpackRGBA ()
             {
                 int dst = 0;
-                while (dst < m_output.Length)
+                for (;;)
                 {
                     byte flags = m_input.ReadByte();
-                    if (0xff == flags)
+                    if (0xff == flags || dst >= m_output.Length)
                         break;
                     int count, pos, src;
 
@@ -255,7 +255,7 @@ void UnpackRGBA ()
                         if (0 != (flags & 0x20))
                             count = ((flags & 0x1f) << 8) + m_input.ReadByte() + 34;
                         else
-                            count = (flags & 0x1f) + 2;			
+                            count = (flags & 0x1f) + 2;
 
                         byte b = m_input.ReadByte();
                         byte g = m_input.ReadByte();
@@ -354,10 +354,10 @@ void UnpackRGBA ()
             public void UnpackAlpha ()
             {
                 int dst = 3;
-                while (dst < m_output.Length)
+                for (;;)
                 {
                     byte flags = m_input.ReadByte();
-                    if (0xff == flags)
+                    if (0xff == flags || dst >= m_output.Length)
                         break;
 
                     int count, pos;
@@ -439,10 +439,10 @@ public void UnpackAlpha ()
             void UnpackRGB ()
             {
                 int dst = 0;
-                while (dst < m_output.Length)
+                for (;;)
                 {
                     byte flags = m_input.ReadByte();
-                    if (0xff == flags)
+                    if (0xff == flags || dst >= m_output.Length)
                         break;
                     int count, pos, src;
                     if (0 == (flags & 0xc0))