Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phpcs.md #967

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update phpcs.md #967

merged 1 commit into from
Apr 16, 2024

Conversation

sharpchi
Copy link
Contributor

Added extra help for configuring in IDE and updating composer

@netlify Netlify
Copy link

netlify bot commented Apr 15, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 482ba73
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/661dffe26c1c360008ada5b2
😎 Deploy Preview https://deploy-preview-967--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 25 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 60 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 76 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 74 🟢 95 🟢 100 🟢 100 🟢 100 Report

@sharpchi
Copy link
Contributor Author

Do you want me to update that lint error?

@sharpchi @andrewnicols
Update phpcs.md
482ba73 
Added extra help for configuring in IDE and updating composer
@andrewnicols andrewnicols added this pull request to the merge queue Apr 16, 2024
Merged via the queue into moodle:main with commit e0c4178 Apr 16, 2024
6 of 7 checks passed
@andrewnicols
Copy link
Member

Hi @sharpchi ,

Ideally yes, but I've done it now :). We block merge on lint failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnicols andrewnicols andrewnicols approved these changes

Assignees

@sharpchi sharpchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharpchi @andrewnicols