Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example/tutorial repo mod_nosferatu for reactive library page #965

Merged

Conversation

Menrath
Copy link
Contributor

@Menrath Menrath commented Apr 12, 2024

This repository turned out to be incredibly helpful for me, I really think it should be referenced on top of the developer resources page for the new reactive library.

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 18d8fff
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6618ed903d72f30008fce9e9
😎 Deploy Preview https://deploy-preview-965--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 12, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 66 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 74 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 81 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 84 🟢 95 🟢 100 🟢 100 🟢 100 Report

@sarjona sarjona force-pushed the add/example-repo-for-reactive-application branch from 519d123 to bfa0d79 Compare April 12, 2024 08:14
@sarjona sarjona force-pushed the add/example-repo-for-reactive-application branch from bfa0d79 to 18d8fff Compare April 12, 2024 08:15
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Menrath!
Thanks a lot for adding this example to the reactive library page! Good idea!
I fixed the problem with the empty line and replaced the new section with a tip admonition.

I'm happy to approve and merge it! :-)

@sarjona sarjona added this pull request to the merge queue Apr 12, 2024
Merged via the queue into moodle:main with commit c3e890b Apr 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants