Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu item margin #964

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix menu item margin #964

merged 2 commits into from
Apr 11, 2024

Conversation

andrewnicols
Copy link
Member

margin-before margin-after

@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 12fd223
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/66177a55916f780008e8f58d
😎 Deploy Preview https://deploy-preview-964--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewnicols andrewnicols requested review from kabalin and sarjona April 11, 2024 05:57
@github-actions GitHub Actions
Copy link
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 82 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 60 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 79 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 81 🟢 95 🟢 100 🟢 100 🟢 100 Report

kabalin
kabalin approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@kabalin kabalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pixel-perfect Andrew 🥳, looks good, thanks!

@andrewnicols andrewnicols enabled auto-merge April 11, 2024 09:03
@andrewnicols andrewnicols added this pull request to the merge queue Apr 11, 2024
Merged via the queue into moodle:main with commit aff722c Apr 11, 2024
8 checks passed
@andrewnicols andrewnicols deleted the fixMenuItemMargin branch April 11, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabalin kabalin kabalin approved these changes

@sarjona sarjona Awaiting requested review from sarjona

Assignees

@andrewnicols andrewnicols

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewnicols @kabalin