Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Add docusaurus cache #963

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

andrewnicols
Copy link
Member

No description provided.

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit a81a266
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/661791d5bcddee00088470d0
😎 Deploy Preview https://deploy-preview-963--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 79 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 72 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 79 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 80 🟢 95 🟢 100 🟢 100 🟢 100 Report

@andrewnicols andrewnicols force-pushed the enableDocusaurusCache branch 7 times, most recently from 176efd1 to 32fa1e8 Compare April 11, 2024 07:30
@andrewnicols andrewnicols force-pushed the enableDocusaurusCache branch from 32fa1e8 to a81a266 Compare April 11, 2024 07:31
@kabalin
Copy link
Collaborator

kabalin commented Apr 11, 2024

Wondering, if we need to specify BUILD_FAST env var, which seems reduce test build to current version of docs only, Docusaurus is using it in GH workflows.

With regard to this change, if it does not have any aversive effects from .docusarus caching, LGTM.

@andrewnicols andrewnicols enabled auto-merge April 16, 2024 04:36
@andrewnicols
Copy link
Member Author

I'd like to avoid the BUILD_FAST as long as possible just because it means we can't review changes on backported docs.

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this improvement, Andrew! And also for clarifying the question that Ruslan raised ;-)
The patch looks good and I'm happy to merge it :-)

@andrewnicols andrewnicols added this pull request to the merge queue Apr 16, 2024
Merged via the queue into moodle:main with commit 51e12fe Apr 16, 2024
6 checks passed
@andrewnicols andrewnicols deleted the enableDocusaurusCache branch April 16, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants