Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 202403.md #927

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Update 202403.md #927

merged 1 commit into from
Mar 20, 2024

Conversation

OlgaKoenig1
Copy link
Contributor

meeting link added

meeting link added
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ae2371
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/65fada7a2d97550008e74f32
😎 Deploy Preview https://deploy-preview-927--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@timhunt timhunt enabled auto-merge March 20, 2024 12:47
@timhunt
Copy link
Collaborator

timhunt commented Mar 20, 2024

Thanks :-)

Copy link
Collaborator

@timhunt timhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@timhunt timhunt added this pull request to the merge queue Mar 20, 2024
Merged via the queue into moodle:main with commit 35aecad Mar 20, 2024
7 of 9 checks passed
Copy link
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 42 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 57 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 72 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 68 🟠 87 🟢 92 🟢 100 🟢 100 Report

@sarjona
Copy link
Member

sarjona commented Mar 20, 2024

@timhunt thanks for merging this. However, before merging it, it's recommended to wait for all the jobs to confirm there are no failures. If you look at the CI - Lint for Pull Requests / docs (pull_request) job, you'll see general/community/meetings/202403.md has a trailing space.

As this file will need to be edited once the meeting finishes, to post the recording, it's OK to leave it there for now (and fix it when it is updated). :-)

@timhunt
Copy link
Collaborator

timhunt commented Mar 20, 2024

Sorry, Sara. The button I clicked said "Merge when ready". I assumed that meant the merge would not proceed if any of the automated checking failed.

Clearly I was wrong about that. I won't do it again. (But also, can we configure it so it works the way I was expecting it to?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants