MDL-77991 - [Docs] Add documentation for how to use the tertiary search #627
Conversation
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Just a couple of minor changes to do with coding style. Looks good to me.
It would be good to also document this in the devupdate.md for 4.3 (https://github.com/moodle/devdocs/blob/main/docs/devupdate.md).
|
Kia ora @andrewnicols, Thanks for checking this out. I am glad it was only some obvious code styling issues to amend. I'll squash down the created commits from accepting your suggestions and I'll look at updating devupdate.md then I'll get back to you. Cheers, |
sarjona
changed the title
sarjona
added
the
blocked-by-tracker
sarjona
changed the title
sarjona
removed
the
blocked-by-tracker
|
I've removed the tag "blocker-by-tracker" because this issue was integrated a few weeks ago. @Chocolate-lightning could you please rebase your branch? TIA! :-) |
|
@Chocolate-lightning is there any chance you can rebase your branch to the latest? TIA! :-) |
Chocolate-lightning
force-pushed
the
tertiarysearching
branch
from
f51bd94 to
3885faf
Compare
sarjona
force-pushed
the
tertiarysearching
branch
from
3885faf to
944b12f
Compare
sarjona
force-pushed
the
tertiarysearching
branch
from
944b12f to
e7e5ac6
Compare
There was a problem hiding this comment.
Hi @Chocolate-lightning!
Thanks for adding this documentation and taking into account Andrew's suggestions.
I've amended your commit adding the missing files (versioned_docs/version-4.3/guides/javascript/comboboxsearch/examples.md and versioned_docs/version-4.3/guides/javascript/comboboxsearch/index.md) to fix the errors raised by GHA checks ;-)
No description provided.