Skip to content

Commit

Permalink
Make codechecker happier
Browse files Browse the repository at this point in the history
  • Loading branch information
abias committed May 30, 2017
1 parent beb18d4 commit e56c4b1
Show file tree
Hide file tree
Showing 7 changed files with 29 additions and 20 deletions.
3 changes: 2 additions & 1 deletion lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
* Atto styles - Library
*
* @package atto_styles
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com> on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com>
on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand Down
3 changes: 2 additions & 1 deletion settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
* Atto styles - Settings file
*
* @package atto_styles
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com> on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com>
on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand Down
4 changes: 2 additions & 2 deletions styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

/* Position menu item icons */
.editor_atto_menu .atto_styles_button .dropdown-menu > li > a i {
width: 15px;
display: inline-block;
height: 15px;
margin-right: 10px;
display: inline-block;
vertical-align: sub;
width: 15px;
}
.editor_atto_menu .atto_styles_button .dropdown-menu > li > a i.inlineelement:before {
content: url([[pix:atto_styles|inline]]);
Expand Down
3 changes: 2 additions & 1 deletion version.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
* Atto styles - Version file
*
* @package atto_styles
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com> on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com>
on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ YUI.add('moodle-atto_styles-button', function (Y, NAME) {
* Atto styles - YUI file
*
* @package atto_styles
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com> on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com>
on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand All @@ -35,6 +36,8 @@ YUI.add('moodle-atto_styles-button', function (Y, NAME) {
* @extends M.editor_atto.EditorPlugin
*/

/*global rangy*/

var component = 'atto_styles';

Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.EditorPlugin, [], {
Expand All @@ -57,8 +60,8 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
span = '<span class="inlinestyle">';
}
items.push({
text: span+icon+style.title+'</span>',
callbackArgs: ['<'+style.type+'>', style.classes]
text: span + icon + style.title + '</span>',
callbackArgs: ['<' + style.type + '>', style.classes]
});
});

Expand Down Expand Up @@ -136,7 +139,7 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
host.toggleInlineSelectionClass([styles[i]]);
}
}
// Mark as updated
// Mark as updated.
this.markUpdated();
},

Expand Down Expand Up @@ -165,5 +168,4 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
});



}, '@VERSION@', {"requires": ["moodle-editor_atto-plugin"]});
12 changes: 7 additions & 5 deletions yui/build/moodle-atto_styles-button/moodle-atto_styles-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ YUI.add('moodle-atto_styles-button', function (Y, NAME) {
* Atto styles - YUI file
*
* @package atto_styles
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com> on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com>
on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand All @@ -35,6 +36,8 @@ YUI.add('moodle-atto_styles-button', function (Y, NAME) {
* @extends M.editor_atto.EditorPlugin
*/

/*global rangy*/

var component = 'atto_styles';

Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.EditorPlugin, [], {
Expand All @@ -57,8 +60,8 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
span = '<span class="inlinestyle">';
}
items.push({
text: span+icon+style.title+'</span>',
callbackArgs: ['<'+style.type+'>', style.classes]
text: span + icon + style.title + '</span>',
callbackArgs: ['<' + style.type + '>', style.classes]
});
});

Expand Down Expand Up @@ -136,7 +139,7 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
host.toggleInlineSelectionClass([styles[i]]);
}
}
// Mark as updated
// Mark as updated.
this.markUpdated();
},

Expand Down Expand Up @@ -165,5 +168,4 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
});



}, '@VERSION@', {"requires": ["moodle-editor_atto-plugin"]});
12 changes: 7 additions & 5 deletions yui/src/button/js/button.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
* Atto styles - YUI file
*
* @package atto_styles
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com> on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @copyright 2015 Andrew Davidson, Synergy Learning UK <andrew.davidson@synergy-learning.com>
on behalf of Alexander Bias, Ulm University <alexander.bias@uni-ulm.de>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand All @@ -33,6 +34,8 @@
* @extends M.editor_atto.EditorPlugin
*/

/*global rangy*/

var component = 'atto_styles';

Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.EditorPlugin, [], {
Expand All @@ -55,8 +58,8 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
span = '<span class="inlinestyle">';
}
items.push({
text: span+icon+style.title+'</span>',
callbackArgs: ['<'+style.type+'>', style.classes]
text: span + icon + style.title + '</span>',
callbackArgs: ['<' + style.type + '>', style.classes]
});
});

Expand Down Expand Up @@ -134,7 +137,7 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
host.toggleInlineSelectionClass([styles[i]]);
}
}
// Mark as updated
// Mark as updated.
this.markUpdated();
},

Expand All @@ -161,4 +164,3 @@ Y.namespace('M.atto_styles').Button = Y.Base.create('button', Y.M.editor_atto.Ed
}
}
});

0 comments on commit e56c4b1

Please sign in to comment.