Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL-2271: Fix appending of clientInfo to appName if it exists #279

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

bucaojit
Copy link
Member

clientInfo was not being added to the application name in the MongoClientSettings. Modified how MongoDriverInformation is built, it only needed the driver name and version.

Tested with Tableau connector:

 "appName": "mongodb-jdbc+2.1.4-7-g3881c65|tableau-connector+1.3.0"

Copy link
Collaborator

@nbagnard nbagnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I love the extra tests, thank you :)

@bucaojit bucaojit added this pull request to the merge queue Aug 14, 2024
Merged via the queue into mongodb:master with commit 1690365 Aug 15, 2024
6 checks passed
@bucaojit bucaojit deleted the SQL-2271 branch August 15, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants