fix: use result of onShow callback in TooltipPopoverCombo #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
onHide can also be cancelled: https://atomiks.github.io/tippyjs/v5/lifecycle-hooks/#onhide. Can we add the same checks there as well?
question: instead of onShow / onHide, should we use different events that won't be cancelled like onMount / onHidden? These do fire at a slightly different point in the lifecycle.
|
I avoided Not sure why we picked onShow/onHide instead of onMount/onUnmount, but for me cancelation is feature which I need to solve a problem in the app. |
Passing the result of the custom (popover and tooltip) onShow/onHide result to tippy as expected. issue: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-623004
maxinteger
force-pushed
the
fix/SPARK-623004-use-result-of-on-show-callback
branch
from
9d3d3f5 to
eb9bee3
Compare
dominiccarrington
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passing the result of the custom (popover and tooltip) onShow result to tippy as expected.
Links
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-623004