Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buttonpill): add disabled outline property #736

Merged

Conversation

chrisadubois
Copy link
Contributor

IMPORTANT

Currently, this project is closed to any external contributions. Any pull request made against this project from external sources will likely be closed. If you would like to make changes to this project, please fork this project.

Guide

This "Help" section can be deleted before submitting this pull request.

Update the name of this pull request to reflect the following shape:

{type}/{scope?}/{message}
  • type - A conventional commit type REQUIRED
  • scope - The kabab-case scope of the changes in this request
  • message - A short, kebab-case statement describing the changes REQUIRED

Provide a general summary of the scope of the changes in this pull request.

Description

  • add a new property called disabledOutline which will work with shallowDisabled, disabled, and outline in tandem to support retaining a border color that does not look disabled, when this property is supplied

Links

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-593171
https://www.figma.com/design/FmXv8xvun1xAZiOMfztwqg/%F0%9F%A7%A9-Webex-App---Web?m=auto&node-id=9578-3178&t=9eAegywB6wgFpf2w-1
webexteams://im?space=09860840-0113-11ef-9cd8-5b34d9c73b9b&message=9a1961e0-b97d-11ef-99dd-17c5b77ef3a4

Screenshot 2024-12-13 at 3 19 56 PM

@chrisadubois chrisadubois added the validated If the pull request is validated automation. label Dec 13, 2024
Copy link
Contributor

@jjkusowski jjkusowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment that should probably be fixed, but since it doesn't change anything, I'll approve.

@chrisadubois chrisadubois merged commit 33d320e into momentum-design:master Dec 16, 2024
5 checks passed
Copy link

🎉 This PR is included in version 26.186.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released validated If the pull request is validated automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants