Feat: #751 show all workspaces to admin #820
Conversation
|
Ran into this bug: The delete workspace endpoint has the same problem. I think this bug needs to be fixed in this PR as well. |
…rovided convert @ to __at__ to match file system
… do with migration and copying
|
I'm suspecting the quality gate above is the right one, not the one in the "checks" part, as that one shows files that were not touched. |
There was a problem hiding this comment.
code looks good, jus small comments.
Will test now.
N.B. I understood file system doesn't care about special characters like umlauts. But you might need to address these? [- _ + ! # $ % & ' * / = ? ^ { | } ~] which as I understand are technically legal or at least confusing as they have special meanings.?
| @@ -29,7 +28,8 @@ public void onApplicationEvent(@NotNull AbstractAuthenticationEvent event) { | |||
| private void onAuthenticationSuccessEvent(AuthenticationSuccessEvent event) { | |||
| publish( | |||
| new AuditEvent( | |||
| getUser(event.getAuthentication().getPrincipal()), | |||
| UserInformationRetriever.getUserIdentifierFromPrincipal( | |||
There was a problem hiding this comment.
waarom heb je deze nieuwe functie niet ook gewoon getUser genoemd? Dat had flink wat code changes verborgen ;-)
There was a problem hiding this comment.
Goede vraag. Ga ik aanpassen haha
| } | ||
|
|
||
| static String getUserBucketName(Principal principal) { | ||
| String userIdentifier = getUserIdentifierFromPrincipal(principal).replace("@", "__at__"); |
There was a problem hiding this comment.
you tested against weird email adresses?
There was a problem hiding this comment.
Probably not, I can add in some tests
marikaris
force-pushed
the
feat/#751-show-all-workspaces-to-admin
branch
from
087868c to
0efa460
Compare
|
New PR because old one got tangled up with the docs PR for some reason.
how to test:
todo: