Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated VCFs #13

Merged
merged 5 commits into from
Jul 26, 2022
Merged

updated VCFs #13

merged 5 commits into from
Jul 26, 2022

Conversation

Bioin4matics
Copy link
Contributor

@Bioin4matics Bioin4matics commented Jul 26, 2022

This change is Reviewable

Copy link
Contributor

@preciserobot preciserobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Bioin4matics)


get_DNANexus_URLs.py line 179 at r2 (raw file):

    """
    raw_data = []
    print('Generating a dictionary:')

what dictionary? The logging output should be informative to someone who is unfamiliar with the underlying code/process.

Copy link
Contributor Author

@Bioin4matics Bioin4matics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @preciserobot)


get_DNANexus_URLs.py line 179 at r2 (raw file):

Previously, preciserobot (David Brawand) wrote…

what dictionary? The logging output should be informative to someone who is unfamiliar with the underlying code/process.

done

Copy link
Contributor

@preciserobot preciserobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Bioin4matics)

@Bioin4matics Bioin4matics merged commit b661589 into main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants