Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Add _SplitlinesIter #3858

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[stdlib] Add _SplitlinesIter #3858

wants to merge 16 commits into from

Conversation

martinvuyk
Copy link
Contributor

Add _SplitlinesIter

This allows lazy iteration over generic line boundaries.

@martinvuyk
Add _SplitlinesIter
898562b 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk requested a review from a team as a code owner December 10, 2024 23:43
@martinvuyk
Merge remote-tracking branch 'upstream/nightly' into add-stringiter-s…
f1546eb 
…plitlines
@martinvuyk
unformat my_module.py
d2bcadf 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk mentioned this pull request Dec 15, 2024
Open
1 task
martinvuyk and others added 5 commits December 17, 2024 14:15
@martinvuyk
Merge branch 'nightly' into add-stringiter-splitlines
f652e52
@martinvuyk
Merge remote-tracking branch 'upstream/nightly' into add-stringiter-s…
d77d51f 
…plitlines
@martinvuyk
add implementation again
257989b 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk
fix docstring
50cffdf 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk
fix docstring
cd2728b 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@skongum02 skongum02 deleted the branch modular:main January 29, 2025 18:59
@skongum02 skongum02 closed this Jan 29, 2025
@skongum02 skongum02 reopened this Jan 29, 2025
@skongum02 skongum02 changed the base branch from nightly to main January 29, 2025 20:37
@martinvuyk
Copy link
Contributor Author

Hi @ConnorGray this kind of iterator is what I had in mind for StringSliceIter to be able to evolve into. Then also have a grapheme iterator, UTF32Iter/UnicodeIter (currently called CharIter which IMO is confusing), etc. Using UTF-8 with a view is simply much more efficient than building a Char which needs to copy and transform data into a UTF-32 format for every iteration.

@martinvuyk martinvuyk mentioned this pull request Feb 1, 2025
Open
@martinvuyk martinvuyk mentioned this pull request Feb 22, 2025
Open
martinvuyk and others added 4 commits February 22, 2025 11:08
@martinvuyk
Merge remote-tracking branch 'upstream/main' into add-stringiter-spli…
8aacc17 
…tlines
@martinvuyk
fix after merge
f67eac0 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk
remove dangling import
661f0a2 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk
Merge branch 'main' into add-stringiter-splitlines
9140abd
@martinvuyk martinvuyk requested a review from a team as a code owner February 27, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gryznar gryznar gryznar left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ConnorGray ConnorGray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinvuyk @gryznar @ConnorGray @skongum02