-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Add Pointer(to=)
and UnsafePointer(to=)
constructors
#3606
Open
martinvuyk
wants to merge
9
commits into
modular:main
Choose a base branch
from
martinvuyk:add-pointer-to-var-constructors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[stdlib] Add Pointer(to=)
and UnsafePointer(to=)
constructors
#3606
martinvuyk
wants to merge
9
commits into
modular:main
from
martinvuyk:add-pointer-to-var-constructors
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
1 task
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
soraros
reviewed
Oct 6, 2024
Blocked by #3617. @VerdagonModular or @lattner - you may be interested in this sort of thing. |
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Pointer(to=)
constructorsPointer(to=)
and UnsafePointer(to=)
constructors
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Great we can finally push this forward |
!sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
Blocked by another issue that must be resolved first
imported-internally
Signals that a given pull request has been imported internally.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Pointer(to=)
andUnsafePointer(to=)
constructors. Closes #3602.The next step would be to replace all uses of
address_of()
to the constructors in a followup PR.