Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Add Pointer(to=) and UnsafePointer(to=) constructors #3606

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

martinvuyk
Copy link
Contributor

@martinvuyk martinvuyk commented Oct 4, 2024

Add Pointer(to=) and UnsafePointer(to=) constructors. Closes #3602.

The next step would be to replace all uses of address_of() to the constructors in a followup PR.

Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk requested a review from a team as a code owner October 4, 2024 18:54
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@JoeLoser JoeLoser added the blocked Blocked by another issue that must be resolved first label Nov 5, 2024
@JoeLoser
Copy link
Collaborator

JoeLoser commented Nov 5, 2024

Blocked by #3617. @VerdagonModular or @lattner - you may be interested in this sort of thing.

@martinvuyk martinvuyk marked this pull request as draft November 6, 2024 15:19
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@skongum02 skongum02 deleted the branch modular:main January 29, 2025 18:58
@skongum02 skongum02 closed this Jan 29, 2025
@skongum02 skongum02 reopened this Jan 29, 2025
@skongum02 skongum02 changed the base branch from nightly to main January 29, 2025 20:50
@martinvuyk martinvuyk changed the title [stdlib] Add Pointer(to=) constructors [stdlib] Add Pointer(to=) and UnsafePointer(to=) constructors Feb 28, 2025
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk marked this pull request as ready for review February 28, 2025 18:54
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@soraros
Copy link
Contributor

soraros commented Feb 28, 2025

Great we can finally push this forward

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by another issue that must be resolved first imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Rename [Unsafe]Pointer.address_of(x) to something shorter
5 participants