Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1d translational lever #4538

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tobolar
Copy link
Contributor

@tobolar tobolar commented Feb 19, 2025

This model is an equivalent to the rotational IdealGear

@tobolar tobolar added the L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational label Feb 19, 2025
@AHaumer AHaumer self-requested a review February 19, 2025 14:02
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, but somehow I don't understand your example:
The lever's pivot is fixed (more or less, via the springDamper), but both masses drift away infinitely, i.e. mass1.s and mass2.s rise without limit.

@tobolar
Copy link
Contributor Author

tobolar commented Feb 19, 2025

somehow I don't understand your example

Yes, physically this makes no sense. For more "reality" look, there could be e.g. a gravity force. But to show the component's functionality, the example is IMO sufficient.

Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be added to ModelicaTest.Translational.AllComponents?

@AHaumer
Copy link
Contributor

AHaumer commented Feb 19, 2025

Yes, physically this makes no sense.
Please provide an example that is not misleading and that makes sense.
How should newbies undestand how to use that component?
You could use that example in ModelicaTest, but not in MSL.
Maybe such a senseless usage should be prevented in the component.

@AHaumer
Copy link
Contributor

AHaumer commented Feb 19, 2025

Additionally, this is not a purely 1d translational movement, it always includes a rotation around the pivot.
I'm not sure whether this component should be part of MSL, especially without a meaningful demo/example.

…arAndLever/comparisonSignals.txt

Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
@tobolar
Copy link
Contributor Author

tobolar commented Feb 20, 2025

Yes, physically this makes no sense.

I have to correct myself. An equivalent example is gearR2T - gearRotational - gearR2T, such as
grafik

So this is indeed a realistic example.

Additionally, this is not a purely 1d translational movement, it always includes a rotation around the pivot.

Probably it is rather the icon which is misleading as it makes an impression a rotational component being involved as the lever's pivot. But it is not. Thinking about the pure 1d translational movement of the two flanges/ends of a real lever, the rotational movement plays no role: ratio = flange_a.s/flange_b.s = y1/y2 = r1 * sin(phi) / r2 * sin(phi) = r1/r2

Maybe I could change the icon to something like the picture above and get off the idea of a lever.

@tobolar
Copy link
Contributor Author

tobolar commented Feb 20, 2025

Should it be added to ModelicaTest.Translational.AllComponents?

IMO the functionality is fully covered with provided test case.

@tobolar tobolar marked this pull request as draft February 20, 2025 16:42
@AHaumer
Copy link
Contributor

AHaumer commented Feb 20, 2025

Nice example with gearR2T + rotationalGear + gearR2T.
Both toothed racks slide with respect to the rotational gear until the maximum length of the racks is reached.
I understand that your component replaces the mentioned combination.
But why a new component? Why not use the mentioned combination?

If you want to model a real lever:
How would such a lever look in reality? A lever always has limited motion.
Could you provide a (rough) sketch to convince me (and other users)?

@tobolar
Copy link
Contributor Author

tobolar commented Feb 21, 2025

But why a new component? Why not use the mentioned combination?

IMO this is an equivalent to rotational gear and, thus, a base element missing so far. Moreover, as I can recognize, the MSL is not just a collection of basic elements. is it?

If you want to model a real lever:

No, I don't. This is an ideal lever (or however called) for simple "scaling" of a translational movement.

@tobolar tobolar force-pushed the addLever_1dTranslational branch 2 times, most recently from 12eed54 to 4fe2358 Compare February 25, 2025 09:01
@tobolar tobolar force-pushed the addLever_1dTranslational branch from 4fe2358 to 383f609 Compare February 25, 2025 09:34
@tobolar
Copy link
Contributor Author

tobolar commented Feb 25, 2025

So, I have renamed the element, changed the icon and the example and adapted the documentation. Hope this make it more understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants