-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add harnesses for safety of primitive conversions #233
Add harnesses for safety of primitive conversions #233
Conversation
140887c
to
26512c1
Compare
ad404e0
to
b33a833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
5ebcf38
to
8ebf05f
Compare
6efe1d0
to
226ae4c
Compare
Hi @ShoyuVanilla -- is this ready for re-review? (And if so, can you request re-review from @tautschnig and I?) |
226ae4c
to
3ddcdbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful macros! I'd ask that you write brief comments above each of them just explaining what they do--especially the distinction between the infallible macro and the harness_pass
one, since that's a bit subtle.
24ccdf1
to
3f962e4
Compare
3f962e4
to
b8bd58b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ff0b5bf
Towards #220
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.