Merge with upstream and update deps (2025-02-10) #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream changed its way of updating GIVTBL. Now it no longer updates generic ivars in gc_update_object_reference, but instead do so for all entries in generic_iv_tbl_ in bulk during weak table updating phase. We still stick to the old method. In the dev/mmtk-overrides-default branch of the mmtk/ruby repo, we will still use the old way, i.e. tracing and forwarding generic ivars when scanning an object, when using MMTk. No change in the Rust part of the code (i.e. this repo) is needed.
We no longer use the HAS_MOVED_GIVTBL bit in the hidden header. Now when we try to get the givtbl of a potentially moved object, we first look up the global general_iv_tbl_ and, if not found, look up the RubyBinding::moved_givtbl table in the Rust part of the binding. There is an associated change in the C part of the binding. It now calls mmtk_hidden_header_is_sane for sanity check.
In addition to `mmtk_{disable,enable}_collection`, we also expose an API
`mmtk_is_collection_enabled` for the Ruby runtime to implement
`GC.disable` and `GC.enable`.
We also expose the `force` and `exhaustive` parameters of
`MMTK::handle_user_collection_request` to the C part so that `GC.start`
can force a GC even when the user disabled GC.
|
The test case I have implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the revision of mmtk-core, ruby and deps. The
rubyrepo is merged with the master branch in the upstream.In the
rubyrepo, the upstream changed the way it updates GIVTBL. They now forward GIVTBL entries in bulk when updating weak tables. We stick to the old way of forwarding entries when scanning an object.We also removed the
HAS_MOVED_GIVTBLbit from the hidden header. Now we use a simpler strategy. We first load from the globalgeneric_iv_tbl_and, if not found, load from themoved_givtbltable in the Rust part of the binding.