Fix crash when trying to create flat multiscale graphs with >= 3 levels #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There is a a bug in
weather-model-graphs/src/weather_model_graphs/create/mesh/kinds/flat.py
Line 8 in 2456064
that causes a crash whenever you try to create a multiscale graph by collapsing >= 3 levels of flat graphs. This is well-described in #33.
This PR fixes this bug and introduces a test for mesh methods that uses multiple levels, to check that they can handle more than 2 levels.
Issue Link
Fixes #33
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee