Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished tests for utils/global with full coverage, will address Eugenes ask for heimdall file interaction testing, identify any type extentions #2221

Closed
wants to merge 5 commits into from

Conversation

aaronlippold
Copy link
Member

@aaronlippold aaronlippold commented Jan 21, 2024

  • utils/global.ts
    • Coverage: 100%
    • Unit tests passing
  • utils/logging.ts
    • Coverage: 33%
    • Unit test for Winston
    • Unit tests for ...

Type Updates

  • There are type and interface extensions that need to be migrated to inspecjs

Signed-off-by: Aaron Lippold <lippold@gmail.com>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
…orgot to push them into the global file to open an issue to extend upstream

Signed-off-by: Aaron Lippold <lippold@gmail.com>
@aaronlippold aaronlippold marked this pull request as draft January 21, 2024 01:55
Signed-off-by: Aaron Lippold <lippold@gmail.com>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

mergify bot commented Jan 21, 2024

This pull request has a conflict. Could you fix it @aaronlippold?

Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request has a conflict. Could you fix it @aaronlippold?

@georgedias
Copy link
Contributor

This PR was incorporated into PR #3065

@georgedias georgedias deleted the global-utils-view-heimdall branch November 20, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants