Add sexp_of cenum attribute, use sexplib0 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sexp_of_* functions now return Sexplib0.Sexp.t instead of Sexplib.Sexp.t. The cenum attribute [@@sexp_of] is like [@@sexp] except it only produces the sexp_of* function. This allows for generating sexp_of converters without depending on the full sexplib library.
|
I found it wasn't too difficult to use sexplib0 instead of sexplib in cstruct-sexp so I went ahead with that. I think it might be possible to entirely move to sexplib0 over sexplib.... |
apparently it's not available at all?!
|
I can't quite figure out macos CI. I note we use avsm/setup-ocaml@v1 -- should we use ocaml/setup-ocaml@v2 instead? And how to migrate? |
|
taking #315 into account, to fix the CI here, maybe we should remove ocaml-migrate-parsetree dependency? |
And no longer ocaml-migrate-parsetree.
the macos-latest target seems to be arm64...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sexp_of_*functions now returnSexplib0.Sexp.tinstead ofSexplib.Sexp.t. Thecenumattribute[@@sexp_of]is like[@@sexp]except it only produces thesexp_of*function. This allows for generatingsexp_ofconverters without depending on the full sexplib library.