Split pos_accounting::PoolData::pledge_amount into pledge and reward
#1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
OBorce
reviewed
Jan 11, 2024
azarovh
force-pushed
the
split_pledge_into_fields
branch
from
7725a93 to
885f020
Compare
TheQuantumPhysicist
approved these changes
Jan 12, 2024
OBorce
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
pledge_amountrepresented original pledge + accumulated reward. This PR splits it into 2 distinct fields to make it possible in the future to spend reward without decommissioning the pool.Note that this PR contains breaking change for api-server database.