Introduce DecimalAmount and refactor wallet controller to use it
#1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iljakuklic
requested review from
erubboli,
TheQuantumPhysicist and
azarovh
as code owners
iljakuklic
force-pushed
the
decimal-amount
branch
2 times, most recently
from
a7ce962 to
e20503e
Compare
It can be used to present amounts to the user since it carries with itself the number of decimal digits to display. It has the capability to be displayed to string and parsed from string and has serde support.
iljakuklic
force-pushed
the
decimal-amount
branch
from
e20503e to
173dd8c
Compare
OBorce
reviewed
Jan 6, 2024
Comment on lines
+96
to
+109
| let mut tokens = BTreeMap::new(); | ||
| for (currency, amount) in balances { | ||
| let token_id = match currency { | ||
| Currency::Coin => panic!("Removed just above"), | ||
| Currency::Token(token_id) => token_id, | ||
| }; | ||
|
|
||
| let info = super::fetch_token_info(&self.rpc_client, token_id).await?; | ||
| let decimals = info.token_number_of_decimals(); | ||
| tokens.insert( | ||
| token_id, | ||
| DecimalAmount::from_amount_minimal(amount, decimals), | ||
| ); | ||
| } |
There was a problem hiding this comment.
One other option I used in the read controller for fetching multiple pool infos from the node was to use FuturesUnordered and try_collect().await to await all of them at once instead of one by one.
TheQuantumPhysicist
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecimalAmountwhich is likeAmountwith formatting information (number of decimals)Amountwas changed to use it under the hood