change the test order

minio · Jan 11, 2024 · 73d576d · 73d576d
1 parent 7abfaaa
commit 73d576d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/internal/keystore/azure/key-vault.go b/internal/keystore/azure/key-vault.go
@@ -417,8 +417,9 @@ func ConnectWithCredentials(_ context.Context, endpoint string, creds Credential
 // instance using an Azure managed identity.
 func ConnectWithIdentity(_ context.Context, endpoint string, msi ManagedIdentity) (*Store, error) {
 	if os.Getenv("AZURE_CLIENT_API_VERSION") != "7.2" {
-		os.Setenv("AZURE_CLIENT_ID", msi.ClientID)
-		cred, err := azidentity.NewDefaultAzureCredential(nil)
+		cred, err := azidentity.NewManagedIdentityCredential(&azidentity.ManagedIdentityCredentialOptions{
+			ID: azidentity.ClientID(msi.ClientID),
+		})
 		if err != nil {
 			return nil, fmt.Errorf("azure: failed to create default Azure credential: %v", err)
 		}

diff --git a/internal/keystore/azure/key-vault_test.go b/internal/keystore/azure/key-vault_test.go
@@ -11,6 +11,7 @@ func TestConnectWithCredentials(t *testing.T) {
 	TenantID := os.Getenv("TenantID")
 	Secret := os.Getenv("Secret")
 	EndPoint := os.Getenv("EndPoint")
+	ManagedIdentityClientID := os.Getenv("ManagedIdentityClientID")
 	if ClientID == "" || TenantID == "" || Secret == "" || EndPoint == "" {
 		t.Skip("Skipping test due to missing credentials")
 	}
@@ -21,11 +22,11 @@ func TestConnectWithCredentials(t *testing.T) {
 		return
 	}
 	os.Setenv("AZURE_CLIENT_API_VERSION", "7.4")
-	c3, err := ConnectWithIdentity(ctx, EndPoint, ManagedIdentity{ClientID: ClientID})
+	c2, err := ConnectWithIdentity(ctx, EndPoint, ManagedIdentity{ClientID: ManagedIdentityClientID})
 	if err != nil {
 		return
 	}
-	c2, err := ConnectWithCredentials(ctx, EndPoint, Credentials{TenantID: TenantID, ClientID: ClientID, Secret: Secret})
+	c3, err := ConnectWithCredentials(ctx, EndPoint, Credentials{TenantID: TenantID, ClientID: ClientID, Secret: Secret})
 	if err != nil {
 		return
 	}