Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation references to _MINIO_BATCH_REPLICATION_WORKERS #1423

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

allanrogerr
Copy link
Contributor

@allanrogerr allanrogerr commented Feb 20, 2025

Hidden env var _MINIO_BATCH_REPLICATION_WORKERS is being referred to in documentation. It needs to be either:

  • removed as a hidden variable
  • renamed with a leading _
  • enabled as a regular variable in minio and eos, without a leading _

See example the files referred to in the PR and https://github.com/minio/minio/blob/39df134204b17336b133ab22256ac17fe72adcd6/cmd/batch-handlers.go#L398

Pending review and discussion with @harshavardhana and @poornas

This PR removes documentation references to this variable.

@allanrogerr allanrogerr self-assigned this Feb 20, 2025
@allanrogerr allanrogerr changed the title Rename _MINIO_BATCH_REPLICATION_WORKERS Remove documentation references to _MINIO_BATCH_REPLICATION_WORKERS Feb 20, 2025
@allanrogerr allanrogerr marked this pull request as draft February 20, 2025 14:22
@allanrogerr
Copy link
Contributor Author

Pending review with @poornas . This var may need to be un-hidden now.

@allanrogerr
Copy link
Contributor Author

After https://github.com/miniohq/eos/pull/451, MINIO_BATCH* vars are no longer undocumented.

@allanrogerr allanrogerr closed this Mar 4, 2025
@allanrogerr
Copy link
Contributor Author

This is the upstream repo. _ MINIO_BATCH vars are still undocumented here.

@allanrogerr allanrogerr reopened this Mar 5, 2025
@allanrogerr allanrogerr marked this pull request as ready for review March 5, 2025 01:01
Copy link
Collaborator

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feorlen feorlen merged commit 942f174 into minio:main Mar 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants