Skip to content

Commit

Permalink
Delete unused telemetry code (#241625)
Browse files Browse the repository at this point in the history
delete unused telemetry
  • Loading branch information
benibenj authored Feb 23, 2025
1 parent 8b14930 commit 199a1b6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 34 deletions.
16 changes: 0 additions & 16 deletions src/vs/workbench/browser/parts/paneCompositeBar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import { IAction, Separator, SubmenuAction, toAction } from '../../../base/commo
import { StringSHA1 } from '../../../base/common/hash.js';
import { GestureEvent } from '../../../base/browser/touch.js';
import { IPaneCompositePart } from './paneCompositePart.js';
import { ITelemetryService } from '../../../platform/telemetry/common/telemetry.js';
import { IConfigurationService } from '../../../platform/configuration/common/configuration.js';
import { IViewsService } from '../../services/views/common/viewsService.js';

Expand Down Expand Up @@ -777,7 +776,6 @@ class ViewContainerActivityAction extends CompositeBarAction {
private readonly part: Parts,
private readonly paneCompositePart: IPaneCompositePart,
@IWorkbenchLayoutService private readonly layoutService: IWorkbenchLayoutService,
@ITelemetryService private readonly telemetryService: ITelemetryService,
@IConfigurationService private readonly configurationService: IConfigurationService,
@IActivityService private readonly activityService: IActivityService,
) {
Expand Down Expand Up @@ -820,36 +818,22 @@ class ViewContainerActivityAction extends CompositeBarAction {
if (sideBarVisible && activeViewlet?.getId() === this.compositeBarActionItem.id) {
switch (focusBehavior) {
case 'focus':
this.logAction('refocus');
this.paneCompositePart.openPaneComposite(this.compositeBarActionItem.id, focus);
break;
case 'toggle':
default:
// Hide sidebar if selected viewlet already visible
this.logAction('hide');
this.layoutService.setPartHidden(true, Parts.SIDEBAR_PART);
break;
}

return;
}

this.logAction('show');
}

await this.paneCompositePart.openPaneComposite(this.compositeBarActionItem.id, focus);
return this.activate();
}

private logAction(action: string) {
type ActivityBarActionClassification = {
owner: 'benibenj';
comment: 'Event logged when an activity bar action is triggered.';
viewletId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The view in the activity bar for which the action was performed.' };
action: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The action that was performed. e.g. "hide", "show", or "refocus"' };
};
this.telemetryService.publicLog2<{ viewletId: String; action: String }, ActivityBarActionClassification>('activityBarAction', { viewletId: this.compositeBarActionItem.id, action });
}
}

class PlaceHolderViewContainerActivityAction extends ViewContainerActivityAction { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -388,24 +388,6 @@ class ConfigurationTelemetryContribution extends Disposable implements IWorkbenc
}>('window.titleBarStyle', { settingValue: this.getValueToReport(key, target), source });
return;

case 'window.customTitleBarVisibility':
this.telemetryService.publicLog2<UpdatedSettingEvent, {
owner: 'benibenj';
comment: 'This is used to know if window custom title bar visibility is configured or not';
settingValue: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'value of the setting' };
source: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'source of the setting' };
}>('window.customTitleBarVisibility', { settingValue: this.getValueToReport(key, target), source });
return;

case 'window.nativeTabs':
this.telemetryService.publicLog2<UpdatedSettingEvent, {
owner: 'benibenj';
comment: 'This is used to know if window native tabs are enabled or not';
settingValue: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'value of the setting' };
source: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'source of the setting' };
}>('window.nativeTabs', { settingValue: this.getValueToReport(key, target), source });
return;

case 'extensions.verifySignature':
this.telemetryService.publicLog2<UpdatedSettingEvent, {
owner: 'sandy081';
Expand Down

0 comments on commit 199a1b6

Please sign in to comment.