TDX: Add a separate usermode-only APIC page for VTL 1 #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
commented
Feb 4, 2025
smalis-msft
commented
Feb 4, 2025
jstarks
reviewed
Feb 5, 2025
smalis-msft
added a commit
that referenced
this pull request
Feb 5, 2025
Introduce a new TdxPrivateRegs struct that is stored per-vtl. This allows userspace operations to operate on arbitrary VTLs, despite the kernel only holding one set of registers. Copy these registers in and out of the shared kernel page on every entry and exit. Remove `pub` from accessors that directly touch private registers in the kernel and add new accessors that allow vtl-shared state to still be accessed. Together with #775 fixes #746.
smalis-msft
changed the title
smalis-msft
force-pushed
the
tdx-apic-hcl-rename
branch
from
f1aed93 to
5a2fbdf
Compare
smalis-msft
commented
Feb 6, 2025
jstarks
reviewed
Feb 7, 2025
|
Discussed offline: move to runner for better safety and to eliminate the macro. |
smalis-msft
force-pushed
the
tdx-apic-hcl-rename
branch
from
8135946 to
79391fe
Compare
auto-merge was automatically disabled
February 19, 2025 18:49
Pull request was converted to draft
smalis-msft
force-pushed
the
tdx-apic-hcl-rename
branch
from
79391fe to
8480a38
Compare
smalis-msft
added a commit
that referenced
this pull request
Feb 20, 2025
This allows Backings in the HCL runner to borrow fields from the HclVp, and ensures that they won't outlive the HclVp. This will be useful for future additions (like the WIP revision on #775), as I plan to add data to these backings that isn't Cloneable.
smalis-msft
force-pushed
the
tdx-apic-hcl-rename
branch
from
8480a38 to
6d11a29
Compare
jstarks
reviewed
Feb 20, 2025
jstarks
reviewed
Feb 20, 2025
jstarks
reviewed
Feb 20, 2025
jstarks
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And rename VTL0's APIC page accessors to make things clearer.
This does not actually register the new page with the cpu yet, but that's not needed to maintain VTL 0 functionality.
Part 1 of #819, fixes #746