-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Test VHD to Ubuntu 24.04 #773
base: main
Are you sure you want to change the base?
Conversation
First run results look like what I remember, vbs failed, but fixing the networking issue makes everything else boot. |
Things I see in a quick scan of the logs: Unable to find the root filesystem (ultimately why we time out)
2025-02-04T00:37:21.6104147Z 2025-02-04T00:33:30.477196Z INFO uefi_log: Begin: Waiting for root file system ... Begin: Running /scripts/local-block ... mdadm: No devices listed in conf file were found. Some MSR access error
2025-02-04T00:37:21.6089072Z 2025-02-04T00:32:54.339964Z INFO uefi_log: [ 44.058367] unchecked MSR access error: WRMSR to 0x40000092 (tried to write 0x00000000001000f3) at rIP: 0xffffffff86ec2b04 (native_write_msr+0x4/0x40) A bunch of post message failures
2025-02-04T00:37:21.6098242Z 2025-02-04T00:32:55.910406Z INFO uefi_log: [ 45.735636] hv_vmbus: hv_post_msg() failed; error code:5 A bunch of PIO errors
2025-02-04T00:37:21.5982178Z 2025-02-04T00:32:43.799936Z INFO openhcl_log: <28>[ 79.700223] vmotherboard::chipset: WARN run_vp{ vp_index=0x1}: device io write error device="uefi" address=0x2e len=0x1 kind=Pio error="invalid access size" bytes=[aa] |
Tests look like they are passing, is there more we need to do here? |
We still want to do some investigation on why VBS fails on the new image, it'd be nice to only be downloading one image. |
Ah got it, that test is running on the old image. |
Is it planned to move all tests using Ubuntu to 24.04? I see some left at 22.04 (it looks like these were changed back to 22.04 in one of the updates to this PR - trying to understand why) |
Looks like there's an issue where VBS does not seem to work with the 24.04 version, if I'm understanding the discussion correctly. |
I came here to make an argument for pushing this change in, if running the tests was the dominant time vs. downloading the images. Look like downloading the images took 1min 29s, whereas running the tests took 7+ minutes in this CI run. That being said: downloading the images is a one-time or few-times pain for devs, whereas running the tests is a frequent-time pain. If we're not going to prioritize the VBS investigation, I think there's a case to be made that completing this PR results in a strictly better experience. But, what do you think? |
@smalis-msft tried this awhile back, trying again. Running CI to see what goes wrong and then hopefully fix any issues. In local testing, the switch reduced the ubuntu boot test from 157 seconds to 35 seconds, due to not waiting for network.
Fixes #385