File Actions menu

[Aaron-Junker]

Summary of the Pull Request

Adding a new menu invokable by selecting files in explorer and pressing a shortcut set in the settings.

Screenshots

PR Checklist

• Closes: New Folder with Selection #3569 copy/move to folder #139 Generate/Verify checksums from file #57 Explorer right click copy image to clipboard (not file) #5256 Replace filename with checksum #25594 Marking and unlocking locked files from context menu #91 Folder collapse (move all files to root) #9269
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated File Actions Menu dev docs #31668
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: [PowerToys]File actions menu docs MicrosoftDocs/windows-dev-docs#5137

Detailed Description of the Pull Request / Additional comments

Things left to do:

• Add installer
• Add icon
• DPI Awareness

Validation Steps Performed

[Aaron-Junker]

@niels9001 Do you have an idea why the contextmenu doesn't take the WPFUI style?

[github-advanced-security]

check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[Aaron-Junker]

@stefansjfw Thank you so much for fixing the issues. Is there anything left I have to do?

[htcfreek]

@Aaron-Junker
Merging in Main and updating GPO info bar(s) on the settings page.

[stefansjfw]

@stefansjfw Thank you so much for fixing the issues. Is there anything left I have to do?

Give it some more testing I guess :) will do the same tomorrow. I also asked @niels9001 to revisit icon and screenshots

[jaimecbernardo]

Code LGTM!
Regarding changes I think we're still missing:
1 - Save file as acts as a "Move to" when there's a conflict and you select "Replace" and as a "Copy to" when there's no conflict. I assume the intended is acting as a "Copy to" everytime?
2 - It's crashing for me when I try to use it on some link files. One example is the shortcut .lnk file for "OBS Studio".
3 - The default Ctrl+Alt+A hotkey will likely conflict with Alt Gr+A on some keyboards. I advise making the default shortcut Ctrl+Win+Alt+A or disable the module by default.
4 - New telemetry needs to be added into "DATA_AND_PRIVACY.md".

In the meanwhile, I've merged latest main, added the "New" badge in Settings and tweaked gpo and spellcheck a bit.

[jaimecbernardo]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Aaron-Junker]

Code LGTM! Regarding changes I think we're still missing: 1 - Save file as acts as a "Move to" when there's a conflict and you select "Replace" and as a "Copy to" when there's no conflict. I assume the intended is acting as a "Copy to" everytime? 2 - It's crashing for me when I try to use it on some link files. One example is the shortcut .lnk file for "OBS Studio". 3 - The default Ctrl+Alt+A hotkey will likely conflict with Alt Gr+A on some keyboards. I advise making the default shortcut Ctrl+Win+Alt+A or disable the module by default. 4 - New telemetry needs to be added into "DATA_AND_PRIVACY.md".

In the meanwhile, I've merged latest main, added the "New" badge in Settings and tweaked gpo and spellcheck a bit.

1. Yes, this is a mistake. I fixed it
2. Don't know why this is happening, but atleast it is not crashing anymore now.
3. I don't think your proposed idea would be easy to press. So I switched it to Ctrl+Shift+A
4. I added them

Thanks again for your review.