Fix #5742: Ensure TermsOfUse is an array in AADConditionalAccessPolicy #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
1781
to
1785
| { | ||
| Write-Verbose -Message "Getting Terms of Use {$TermsOfUse}" | ||
| $TermsOfUseObj = Get-MgBetaAgreement | Where-Object -FilterScript { $_.DisplayName -eq $TermsOfUse } | ||
| $GrantControls.Add('termsOfUse', @($TermsOfUseObj.Id)) | ||
| } |
There was a problem hiding this comment.
@Pranaykarvi Is it only the view or did the indentation change? Please keep it the same as it was previously, thank you.
There was a problem hiding this comment.
@FabienTschanz i have resolved the indentation and is now same as it was previously
|
@FabienTschanz I have also made an entry to the changelog |
CHANGELOG.md
Outdated
| @@ -23,6 +23,9 @@ | |||
| * TeamsM365App | |||
| * Remove `Ensure` property from being exported. | |||
| FIXES [#5781](https://github.com/microsoft/Microsoft365DSC/issues/5781) | |||
| * **AADConditionalAccessPolicy** | |||
There was a problem hiding this comment.
Can you remove the double stars ** please? I guess they were mistakenly added.
There was a problem hiding this comment.
@FabienTschanz done, can you please check now?
Co-authored-by: Fabien Tschanz <71251572+FabienTschanz@users.noreply.github.com>
|
@NikCharlebois LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #5742
Summary
MSFT_AADConditionalAccessPolicy.psm1to wrap TermsOfUse ID in@().Changes Made
Modules/Microsoft365DSC/DSCResources/MSFT_AADConditionalAccessPolicy/MSFT_AADConditionalAccessPolicy.psm1$TermsOfUseObj.Idin an array to ensure compliance.Issue Reference
Fixes #5742