-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows 365 Baseline #5699
base: Dev
Are you sure you want to change the base?
Add Windows 365 Baseline #5699
Conversation
Platforms = $enumPlatforms | ||
RoleScopeTagIds = $getValue.RoleScopeTagIds | ||
Technologies = $enumTechnologies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$enumPlatforms
and $enumTechnologies
are not defined.
if ($CurrentValues.Ensure -ne $Ensure) | ||
{ | ||
Write-Verbose -Message "Test-TargetResource returned $false" | ||
return $false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this Ensure check. The handling of Ensure is done in Test-M365DSCParameterState
on line 1848.
# IntuneSecurityBaselineWindows356 | ||
|
||
## Description | ||
|
||
Intune Security Baseline Windows356 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows356 instead of Windows365
"resourceName":"IntuneSecurityBaselineWindows356", | ||
"description":"This resource configures an Intune Security Baseline Windows356.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also Windows356 instead of Windows365
|
||
node localhost | ||
{ | ||
IntuneSecurityBaselineWindows10 'mySecurityBaselineWindows365' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example does not match expected resource: IntuneSecurityBaselineWindows365
|
||
node localhost | ||
{ | ||
IntuneSecurityBaselineWindows10 'mySecurityBaselineWindows365' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example does not match expected resource: IntuneSecurityBaselineWindows365
|
||
node localhost | ||
{ | ||
IntuneSecurityBaselineWindows10 'mySecurityBaselineWindows365' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example does not match expected resource: IntuneSecurityBaselineWindows365
73a182e
to
8ea2209
Compare
8ea2209
to
cdb98cd
Compare
@NikCharlebois PR review for your review. I co-authored the resource and checked its functionality. All good from my side. |
Pull Request (PR) description
Add Intune Security Baseline for Windows 365.
please note: does not yet work because of nested cim instance escaping of double quotes. @FabienTschanz is aware of it
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).