Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 365 Baseline #5699

Open
wants to merge 10 commits into
base: Dev
Choose a base branch
from

Conversation

nee-source
Copy link

Pull Request (PR) description

Add Intune Security Baseline for Windows 365.

please note: does not yet work because of nested cim instance escaping of double quotes. @FabienTschanz is aware of it

This Pull Request (PR) fixes the following issues

Task list

  • [ x ] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • [ x ] Resource parameter descriptions added/updated in the schema.mof.
  • [ x ] Resource documentation added/updated in README.md.
  • [ x ] Resource settings.json file contains all required permissions.
  • [ x ] Examples appropriately added/updated.
  • [ x ] Unit tests added/updated.
  • [ x ] New/changed code adheres to DSC Community Style Guidelines.

Comment on lines 1516 to 1518
Platforms = $enumPlatforms
RoleScopeTagIds = $getValue.RoleScopeTagIds
Technologies = $enumTechnologies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$enumPlatforms and $enumTechnologies are not defined.

Comment on lines 1813 to 1817
if ($CurrentValues.Ensure -ne $Ensure)
{
Write-Verbose -Message "Test-TargetResource returned $false"
return $false
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this Ensure check. The handling of Ensure is done in Test-M365DSCParameterState on line 1848.

Comment on lines 2 to 6
# IntuneSecurityBaselineWindows356

## Description

Intune Security Baseline Windows356
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows356 instead of Windows365

Comment on lines 2 to 3
"resourceName":"IntuneSecurityBaselineWindows356",
"description":"This resource configures an Intune Security Baseline Windows356.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Windows356 instead of Windows365


node localhost
{
IntuneSecurityBaselineWindows10 'mySecurityBaselineWindows365'
Copy link
Collaborator

@FabienTschanz FabienTschanz Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example does not match expected resource: IntuneSecurityBaselineWindows365


node localhost
{
IntuneSecurityBaselineWindows10 'mySecurityBaselineWindows365'
Copy link
Collaborator

@FabienTschanz FabienTschanz Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example does not match expected resource: IntuneSecurityBaselineWindows365


node localhost
{
IntuneSecurityBaselineWindows10 'mySecurityBaselineWindows365'
Copy link
Collaborator

@FabienTschanz FabienTschanz Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example does not match expected resource: IntuneSecurityBaselineWindows365

@nee-source nee-source force-pushed the feat/windows-365-baseline branch from 73a182e to 8ea2209 Compare February 12, 2025 15:48
@nee-source nee-source force-pushed the feat/windows-365-baseline branch from 8ea2209 to cdb98cd Compare February 12, 2025 15:50
@FabienTschanz
Copy link
Collaborator

@NikCharlebois PR review for your review. I co-authored the resource and checked its functionality. All good from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewResourceName: Microsoft Intune - Security Baselines
2 participants