Fixes #455: getThumb orientation fix for vertical sliders #456
+1
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just set
trackClickable
tofalse
on my vertical slider, and suddenly I can't scrub it downwards. Upwards works okay, but scrubbing downwards is broken.I've tracked this down to the
_getThumbLeft
function, which usesvertical
to discern between containerwidth
andheight
. However, my container seems to have a "width" of its visible height – not of its visible width. So the "width" is the draggable axis of the slider?So the X and Y values are already flipped, but the function seems to be calculating incorrectly.
When the track is clickable, this resolves itself because clicking the track automatically jumps to the right position. But without that prop, the handle isn't scrubbable in a vertical context.