fix: add signal handling and resource cleanup #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cmd/serve.go
Outdated
| go func() { | ||
| <-ctx.Done() | ||
| out.Info("Shutting down troubleshoot-live...") | ||
| s.Shutdown(ctx) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of s.Shutdown is not checked (errcheck)
cmd/serve.go
Outdated
| @@ -113,8 +117,20 @@ func runServe(bundlePath string, o *serveOptions, out output.Output) error { | |||
| proxyHandler := proxy.New(testEnv.Config, supportBundle, rewriter.Default()) | |||
| loggedProxyHandler := handlers.LoggingHandler(out.InfoWriter(), proxyHandler) | |||
|
|
|||
| http.Handle("/", loggedProxyHandler) | |||
| return http.ListenAndServe(o.proxyAddress, nil) //nolint:gosec // not a production server | |||
| s := http.Server{Addr: o.proxyAddress, Handler: loggedProxyHandler} | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
mhrabovcin
force-pushed
the
cleanup-resources
branch
from
91222d2 to
fd3fa6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.