Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better description for artifact-path #147

Closed
wants to merge 1 commit into from

Conversation

maxandersen
Copy link

artifact-path does not actually provide the path on disk, but more the expected relative path of a given GAV.

@@ -20,7 +20,7 @@
/**
* Prints Maven Artifact path in local repository.
*/
@CommandLine.Command(name = "artifact-path", description = "Prints path of Maven Artifacts in local repository")
@CommandLine.Command(name = "artifact-path", description = "Prints expected relvative path for a given Maven coordinate in a local repository")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@CommandLine.Command(name = "artifact-path", description = "Prints expected relvative path for a given Maven coordinate in a local repository")
@CommandLine.Command(name = "artifact-path", description = "Prints expected relative path for a given Maven coordinate in a local repository")

@cstamas
Copy link
Member

cstamas commented Dec 10, 2024

Yes, sorry for not being clearer, these new mojos in PR #143
are used in new Maven ITs as part of "tool:
https://github.com/apache/maven/blob/master/impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java

Original Verifier used to run ITs contained "path logic" (calculating GAV to path) that made it impossible to use things like "split local repo" in ITs (as verifier a) had no idea about it, and b) would return totally off paths). Hence, the initial step is Maven ITs already done is that we "ask maven about whereabouts of given artifact in local repo".

@cstamas
Copy link
Member

cstamas commented Dec 10, 2024

Superseded by #148

@cstamas cstamas closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants