refactor!(timeline): simplify getting the RepliedToInfo + introduce Room::load_or_fetch_event()
#4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4837 +/- ##
==========================================
- Coverage 86.45% 86.45% -0.01%
==========================================
Files 297 297
Lines 34625 34599 -26
==========================================
- Hits 29936 29913 -23
+ Misses 4689 4686 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bnjbvr
force-pushed
the
bnjbvr/timeline-reply-simplification
branch
from
cc29b97 to
f057959
Compare
poljar
approved these changes
Mar 25, 2025
bnjbvr
commented
Mar 25, 2025
…h the replied-to event content This is a nice simplification, because this means that: 1. we use a single way to get the event (event-cache-or-network) 2. we don't have to reconstruct a `RoomMessageEventContent` from a timeline's message, which seems a bit error prone 3. there's a single way to get the replied-to info for an event, 4. and that's actually independent of the timeline, so we can improve the code for #4835
bnjbvr
force-pushed
the
bnjbvr/timeline-reply-simplification
branch
from
f057959 to
44882ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring which should help with #4835.
Also introduces a new way to retrieve an event from the event cache, or if it's missing, from the network.