Commit b4aff96
1 file changed
+0
-4
lines changedOriginal file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
20 | 20 |
| |
21 | 21 |
| |
22 | 22 |
| |
23 |
| - | |
24 |
| - | |
25 |
| - | |
26 |
| - | |
27 | 23 |
| |
28 | 24 |
| |
29 | 25 |
| |
|
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
20 | 20 |
| |
21 | 21 |
| |
22 | 22 |
| |
23 |
| - | |
24 |
| - | |
25 |
| - | |
26 |
| - | |
27 | 23 |
| |
28 | 24 |
| |
29 | 25 |
| |
|
7 commit comments
callumacrae commentedon Mar 11, 2015
@feross: Could you push this to npm?
feross commentedon Mar 11, 2015
Done. Now that this change is in, I don't need to maintain a fork to remove
private: true
. Who is the current maintainer of this module, and would they like to be an npm owner?callumacrae commentedon Mar 11, 2015
It's still not commonJS compatible and relies on
window.$
: I have a PR with a fix in but it has been ignored so far.I'd be willing to maintain a fork with commonJS compatibility if you no longer want to update your fork and the maintainers of this module don't want support in the actual library—we use this library at work so I'd keep it up to date.
feross commentedon Mar 11, 2015
sure, i don't use this module anymore. what's your npm username?
callumacrae commentedon Mar 11, 2015
It's callumacrae again. Thanks!
feross commentedon Mar 11, 2015
callumacrae commentedon Mar 11, 2015
Awesome, I'll push my commonjs stuff up next time the developers make a release (unless they merge it here!)