New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix period string representation #152

Merged

manusimidt merged 1 commit into manusimidt:main from rossbowen:fix-period-string

Feb 11, 2025

Contributor

rossbowen commented Feb 10, 2025

Hey @manusimidt, I was looking at the XBRL-JSON spec and noticed:

period (string)

A valid period string representation for the {interval} property of the period core dimension, if present. See Example 2 and Example 3.

The period string representation casts dates to datetimes when output in the JSON. It says:

It should be noted that unlike the xbrli:dateUnion type used in xBRL-XML, the xs:dateTime datatype used here does not allow the time component to be omitted.

I've made a small change here to output the times alongside dates. Thanks!


          Fix period string representation

0fd9fdc

manusimidt self-requested a review

February 11, 2025 17:32

Owner

manusimidt commented Feb 11, 2025

Looks good, true the spec defines also the time, not only the date. Thanks @rossbowen

manusimidt merged commit b35e861 into manusimidt:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet