Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix unit tests on Windows #308

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

L2jLiga
Copy link
Contributor

@L2jLiga L2jLiga commented Aug 2, 2024

most of failures were related to "/" vs "" in paths,
I've wrapped them in normalize from node:path module
to replace path delimiter character with proper one for
current OS.

@L2jLiga L2jLiga changed the title chore/fix unit tests chore: fix unit tests on Windows Aug 2, 2024
@L2jLiga L2jLiga force-pushed the chore/fix-unit-tests branch from f9a7944 to 919a8d0 Compare August 2, 2024 06:50
@mantoni mantoni merged commit daa2a1a into mantoni:master Aug 2, 2024
3 checks passed
@mantoni
Copy link
Owner

mantoni commented Aug 2, 2024

Nice! Thank you 🙏

@L2jLiga L2jLiga deleted the chore/fix-unit-tests branch September 26, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants