Add --fix-to-stdout back

[DamienCassou]

This is fixing #295.

[DamienCassou]

The code quality is not there yet but I would appreciate early feedback if you have any.

[mantoni]

Thanks for starting this! ❤️

I left some minor comments. Generally the idea seems fine. 👍

Error cases should probably always print to console.error and write the input to stdout, so that the original text is preserved. Could be annoying otherwise. What do you think?

[DamienCassou]

I improved the code following your review and added a few tests. I need to write more tests and add support for older versions of eslint. Feel free to give me more feedback if you see anything I should pay attention to.

My main problem is that integration tests are flaky now. For the same code, they sometimes pass and sometimes fail:

• this one passes: https://github.com/mantoni/eslint_d.js/actions/runs/10163981223
• this one fails: https://github.com/mantoni/eslint_d.js/actions/runs/10163952276

Given that the integration tests depend on each other (the suite uses after() and not afterEach()), I find it hard to debug. Would you consider having each test independent of the other ones? This way, they would run regardless of the order and running only one test (with it.only() for example) would trigger the same code as if the test was run after another one.

[mantoni]

Nice! Regarding the integration test:

They depend on each other since the first ones start the server, then check for --version and status etc. which I think makes sense.

However, feel free to create a new group for the --fix-to-stdout tests with a before that starts the daemon and an after that stops it. This way you can use only on each of the new tests.

[mantoni]

Looking good. I have no more feedback. This just needs tests and the integration tests to pass.

How do you want to proceed regarding the exit code protocol?

[DamienCassou]

We are in a much better state now. The first 4 commits are the same as in #301 so only the last 2 make sense for this one. I think I only need to write a few unit-tests now. As always, feedback appreciated (but you may want to spend your time on #301 instead of this one for now).

[mantoni]

📦 Released in v14.0.2 via #307 – Thank you so much @DamienCassou for the idea and stepping up to actually do the legwork. Highly appreciated. 🙌