Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on admin product edit page when all product attributes are globally scoped #39648

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

mfickers
Copy link
Contributor

If there are no product attributes set to scopes website or store, the ScopeOverriddenValue class will produce an empty SQL query, which results in this Error:

ValueError: PDO::prepare(): Argument #1 ($query) cannot be empty in /var/www/html/vendor/magento/zend-db/library/Zend/Db/Statement/Pdo.php:58

Description (*)

If there are no $selects, then the remaining function does nothing and we can return early.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Admin product page error when all product attributes are set to global scope #39646

Manual testing scenarios (*)

  1. Set all product attributes to global scope
UPDATE catalog_eav_attribute 
SET is_global = 1 
WHERE attribute_id IN (
    SELECT attribute_id FROM eav_attribute 
    WHERE entity_type_id = (SELECT entity_type_id FROM eav_entity_type WHERE entity_type_code = 'catalog_product')
);
  1. Navigate to product grid in admin panel
  2. Click on "Add Product"

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Feb 20, 2025

Hi @mfickers. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Basecom partners-contribution Pull Request is created by Magento Partner labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Basecom partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin product page error when all product attributes are set to global scope
2 participants