Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a more descriptive error message rather than generic #39643

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

ssx
Copy link
Contributor

@ssx ssx commented Feb 20, 2025

The current output of 'Invalid file name' isn't useful for anyone, it then needs to be debugged to find the culprit that no longer exists. This changes saves the debugging step and informs the user of the problematic image straight away.

ssx added 2 commits February 20, 2025 10:52
The current output of 'Invalid file name' isn't useful for anyone, it then needs to be debugged to find the culprit that no longer exists. This changes saves the debugging step and informs the user of the problematic image straight away.
…eption

Provide a more descriptive error message rather than generic
Copy link

m2-assistant bot commented Feb 20, 2025

Hi @ssx. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant