Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQl Custom Attributes Options output need optimization #39614

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

zakdma
Copy link
Contributor

@zakdma zakdma commented Feb 10, 2025

Description (*)

Pool request to fix performance issue
#39613

Class \Magento\EavGraphQl\Model\Output\Value\Options\GetCustomSelectedOptionAttributes is not optimized for attributes with huge amounts of options (> 10000).
Request like this take too much time to retrieve such custom attributes selected values

query {
    products(
      filter: { category_id: { eq: "2"}}
    ) {
        total_count
        items {
            name
            sku
            custom_attributesV2(filters: {used_in_product_listing: true}) {
              items {
                code
                label
                ... on AttributeValue {
                      value
                    }
                ... on AttributeSelectedOptions {
                      selected_options {
                        label
                        value
                      }
                    }
              }
            }
        }
    }
 }

The acceleration was from 3 to 4 times for my project.

Related Pull Requests

none

Fixed Issues (if relevant)

  1. Fixes GraphQl Custom Attributes Options output need optimization #39613

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Feb 10, 2025

Hi @zakdma. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@zakdma
Copy link
Contributor Author

zakdma commented Feb 10, 2025

@magento run all tests

@zakdma
Copy link
Contributor Author

zakdma commented Feb 10, 2025

@magento run Magento Health Index, Static Tests, WebAPI Tests

@zakdma
Copy link
Contributor Author

zakdma commented Feb 10, 2025

@magento stop all tests

@zakdma
Copy link
Contributor Author

zakdma commented Feb 10, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQl Custom Attributes Options output need optimization
2 participants