added lightweight possibility to add enchants into existing entries #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just one small thing I figured that was not possible yet..
If you add an enchanted book on a GeneratorItem, you will now get an updated "custom" lore from the '%ENCHANTS%' placeholder.
However, this is pretty lightweight and might give potential to have updates soon. Atm, there is no reliable way to detect on which position (including all other filled placeholders) unless there is at least one enchantment available. If thats not the case, we simply add a '%ENCHANTS%'-placeholder at the end of a lore, if its not hidden by an Item-Flag.