Skip to content

Commit

Permalink
1.6.0
Browse files Browse the repository at this point in the history
  • Loading branch information
dmitrii-fediuk committed Oct 10, 2017
1 parent 05ad240 commit 32e66fe
Show file tree
Hide file tree
Showing 9 changed files with 31 additions and 45 deletions.
40 changes: 13 additions & 27 deletions Facade/Charge.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,29 +23,16 @@ final class Charge extends \Df\StripeClone\Facade\Charge {
* @return oCharge
*/
function capturePreauthorized($id, $a) {
/** @var oCharge $oCharge */
$oCharge = $this->load($id);
$oCharge = $this->load($id); /** @var oCharge $oCharge */
return $this->api()->create((new iCharge)
// 2019-02-19
// Для перестраховки от конверсионных погрешностей не используем $a.
// 2019-02-19 Для перестраховки от конверсионных погрешностей не используем $a.
->setAmount($oCharge->getAmount())
->setDescription($oCharge->getDescription())
->setCurrency($oCharge->getCurrency())
->setPreauthorization($oCharge->getPreauthorization()->getId())
);
}

/**
* 2017-02-11
* Идентификаторы банковских карт (в терминологии Paymill - «Payment») имеют вид
* «pay_ddcc9210289ede708c97eb67».
* @override
* @see \Df\StripeClone\Facade\Charge::cardIdPrefix()
* @used-by \Df\StripeClone\Payer::usePreviousCard()
* @return string
*/
function cardIdPrefix() {return 'pay';}

/**
* 2017-02-10
* @override
Expand All @@ -55,18 +42,16 @@ function cardIdPrefix() {return 'pay';}
* @return oCharge
*/
function create(array $p) {
/** @var bool $capture */
$capture = $p[_Charge::K_CAPTURE];
$capture = $p[_Charge::K_CAPTURE]; /** @var bool $capture */
// 2017-02-12
// Приходится заводить эту переменную, потому что иначе интерпретатор PHP даёт сбой:
// «syntax error, unexpected '->' (T_OBJECT_OPERATOR)».
/** @var iCharge|iAuth $i */
$i = $capture ? new iCharge : new iAuth;
$i = $capture ? new iCharge : new iAuth; /** @var iCharge|iAuth $i */
/** @var oCharge|oAuth $o */
$o = $this->api()->create($i
->setAmount($p[_Charge::K_AMOUNT])
->setDescription($p[_Charge::K_DESCRIPTION])
->setClient($p[_Charge::K_CUSTOMER])
->setClient($p[_Charge::K_CUSTOMER_ID])
->setCurrency($p[_Charge::K_CURRENCY])
->setPayment($p[_Charge::K_CARD])
);
Expand Down Expand Up @@ -95,6 +80,7 @@ function id($c) {return $c->getId();}
* @override
* @see \Df\StripeClone\Facade\Charge::pathToCard()
* @used-by \Df\StripeClone\Block\Info::prepare()
* @used-by \Df\StripeClone\Facade\Charge::cardData()
* @return string
*/
function pathToCard() {return 'payment';}
Expand Down Expand Up @@ -127,15 +113,15 @@ function void($id) {return $this->api()->delete(
);}

/**
* 2017-02-11 The bank card data.
* 2017-02-11
* Идентификаторы банковских карт (в терминологии Paymill - «Payment») имеют вид
* «pay_ddcc9210289ede708c97eb67».
* @override
* @see \Df\StripeClone\Facade\Charge::cardData()
* @used-by \Df\StripeClone\Facade\Charge::card()
* @param oCharge $c
* @return oCard
* @see \Dfe\Paymill\Facade\Customer::cardsData()
* @see \Df\StripeClone\Facade\Charge::cardIdPrefix()
* @used-by \Df\StripeClone\Payer::usePreviousCard()
* @return string
*/
protected function cardData($c) {return $c->getPayment();}
protected function cardIdPrefix() {return 'pay_';}

/**
* 2017-02-11
Expand Down
20 changes: 10 additions & 10 deletions Facade/Customer.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@
// 2017-02-10
/** @method \Dfe\Paymill\Method m() */
final class Customer extends \Df\StripeClone\Facade\Customer {
/**
* 2017-02-10
* @override
* @see \Df\StripeClone\Facade\Customer::_get()
* @used-by \Df\StripeClone\Facade\Customer::get()
* @param int $id
* @return C|null
*/
function _get($id) {return $this->api()->getOne((new iCustomer)->setId($id));}

/**
* 2017-02-10
* @override
Expand Down Expand Up @@ -67,6 +57,16 @@ function create(array $p) {
*/
function id($c) {return $c->getId();}

/**
* 2017-02-10
* @override
* @see \Df\StripeClone\Facade\Customer::_get()
* @used-by \Df\StripeClone\Facade\Customer::get()
* @param int $id
* @return C|null
*/
protected function _get($id) {return $this->api()->getOne((new iCustomer)->setId($id));}

/**
* 2017-02-11
* @override
Expand Down
2 changes: 1 addition & 1 deletion P/Charge.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
final class Charge extends \Df\StripeClone\P\Charge {
/**
* 2017-02-11
* 2017-02-18 Ключ, значением которого является токен банковской карты.
* 2017-10-09 The key name of a bank card token or of a saved bank card ID.
* @override
* @see \Df\StripeClone\P\Charge::k_CardId()
* @used-by \Df\StripeClone\P\Charge::request()
Expand Down
2 changes: 1 addition & 1 deletion T/Auth.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use Paymill\Models\Request\Preauthorization as iAuth;
use Paymill\Models\Response\Preauthorization as oAuth;
// 2017-02-12
final class Auth extends TestCase {
final class Auth extends CaseT {
/**
* 2017-02-12
* [Paymill] An example of a preauthorization response: https://mage2.pro/t/2731
Expand Down
2 changes: 1 addition & 1 deletion T/Card.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
use Paymill\Models\Request\Payment as iCard;
use Paymill\Models\Response\Payment as oCard;
use Paymill\Request as API;
final class Card extends TestCase {
final class Card extends CaseT {
/** @test 2017-02-08 */
function t00() {}

Expand Down
2 changes: 1 addition & 1 deletion T/TestCase.php → T/CaseT.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* @see \Dfe\Paymill\T\Customer
* @method \Dfe\Paymill\Settings s()
*/
abstract class TestCase extends \Df\Core\TestCase {
abstract class CaseT extends \Df\Core\TestCase {
/**
* 2017-02-08
* @return API
Expand Down
2 changes: 1 addition & 1 deletion T/Charge.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Paymill\Models\Response\Payment as oCard;
use Paymill\Models\Response\Transaction as oCharge;
use Paymill\Request as lRequest;
final class Charge extends TestCase {
final class Charge extends CaseT {
/** @test */
function t00() {}

Expand Down
2 changes: 1 addition & 1 deletion T/Customer.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use Paymill\Models\Response\Client as oCustomer;
use Paymill\Models\Response\Payment as oCard;
use Paymill\Request as API;
final class Customer extends TestCase {
final class Customer extends CaseT {
/** @test */
function t00() {}

Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mage2pro/paymill"
,"version": "1.5.8"
,"version": "1.6.0"
,"description": "The «Paymill» payment extension for Magento 2."
,"type": "magento2-module"
,"homepage": "https://mage2.pro/c/extensions/paymill"
Expand All @@ -11,7 +11,7 @@
"homepage": "https://mage2.pro/users/dmitry_fedyuk",
"role": "Developer"
}]
,"require": {"mage2pro/core": ">=2.12.21", "mage2pro/paymill-sdk": "^4.4.4"}
,"require": {"mage2pro/core": ">=3.1.0", "mage2pro/paymill-sdk": "^4.4.4"}
,"autoload": {"files": ["registration.php"], "psr-4": {"Dfe\\Paymill\\": ""}}
,"keywords": [
"3D Secure"
Expand Down

0 comments on commit 32e66fe

Please sign in to comment.